diff --git a/benchmark/napi/function_args/binding.cc b/benchmark/napi/function_args/binding.cc index 9f250aaa83db50..2c54dd424d405d 100644 --- a/benchmark/napi/function_args/binding.cc +++ b/benchmark/napi/function_args/binding.cc @@ -2,18 +2,20 @@ #include #include -using v8::Isolate; +using v8::Array; +using v8::ArrayBuffer; +using v8::ArrayBufferView; +using v8::BackingStore; using v8::Context; +using v8::FunctionCallbackInfo; +using v8::Isolate; using v8::Local; using v8::MaybeLocal; -using v8::Value; using v8::Number; -using v8::String; using v8::Object; -using v8::Array; -using v8::ArrayBufferView; -using v8::ArrayBuffer; -using v8::FunctionCallbackInfo; +using v8::String; +using v8::Uint32; +using v8::Value; void CallWithString(const FunctionCallbackInfo& args) { assert(args.Length() == 1 && args[0]->IsString()); @@ -22,7 +24,7 @@ void CallWithString(const FunctionCallbackInfo& args) { const int32_t length = str->Utf8Length(args.GetIsolate()) + 1; char* buf = new char[length]; str->WriteUtf8(args.GetIsolate(), buf, length); - delete [] buf; + delete[] buf; } } @@ -31,7 +33,7 @@ void CallWithArray(const FunctionCallbackInfo& args) { if (args.Length() == 1 && args[0]->IsArray()) { const Local array = args[0].As(); uint32_t length = array->Length(); - for (uint32_t i = 0; i < length; ++ i) { + for (uint32_t i = 0; i < length; i++) { Local v; v = array->Get(args.GetIsolate()->GetCurrentContext(), i).ToLocalChecked(); @@ -101,12 +103,10 @@ void CallWithTypedarray(const FunctionCallbackInfo& args) { const size_t byte_length = view->ByteLength(); assert(byte_length > 0); assert(view->HasBuffer()); - Local buffer; - buffer = view->Buffer(); - ArrayBuffer::Contents contents; - contents = buffer->GetContents(); + Local buffer = view->Buffer(); + std::shared_ptr bs = buffer->GetBackingStore(); const uint32_t* data = reinterpret_cast( - static_cast(contents.Data()) + byte_offset); + static_cast(bs->Data()) + byte_offset); assert(data); } } @@ -114,11 +114,11 @@ void CallWithTypedarray(const FunctionCallbackInfo& args) { void CallWithArguments(const FunctionCallbackInfo& args) { assert(args.Length() > 1 && args[0]->IsNumber()); if (args.Length() > 1 && args[0]->IsNumber()) { - int32_t loop = args[0].As()->Value(); + int32_t loop = args[0].As()->Value(); for (int32_t i = 1; i < loop; ++i) { assert(i < args.Length()); assert(args[i]->IsUint32()); - args[i].As()->Value(); + args[i].As()->Value(); } } }