Skip to content

Commit

Permalink
deps: cherry-pick 09bca09 from upstream V8
Browse files Browse the repository at this point in the history
Original commit message:

    [postmortem] add ScopeInfo and Context types

    The metadata introduced in this patch will be useful for postmortem
    tools to inspect Contexts and ScopeInfos (see
    nodejs/llnode#211).

    R=bmeurer@google.com, yangguo@google.com

    Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95
    Reviewed-on: https://chromium-review.googlesource.com/1153858
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54768}

Refs: v8/v8@09bca09

PR-URL: #22068
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
Matheus Marchini authored and targos committed Aug 11, 2018
1 parent 4e6be4c commit e1dcb79
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions deps/v8/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -828,6 +828,7 @@ action("postmortem-metadata") {
"src/objects/js-regexp-string-iterator.h",
"src/objects/map.h",
"src/objects/map-inl.h",
"src/objects/scope-info.h",
"src/objects/script.h",
"src/objects/script-inl.h",
"src/objects/shared-function-info.h",
Expand Down
1 change: 1 addition & 0 deletions deps/v8/gypfiles/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -2948,6 +2948,7 @@
'../src/objects/js-regexp-string-iterator.h',
'../src/objects/map.h',
'../src/objects/map-inl.h',
'../src/objects/scope-info.h',
'../src/objects/script.h',
'../src/objects/script-inl.h',
'../src/objects/shared-function-info.h',
Expand Down
5 changes: 4 additions & 1 deletion deps/v8/tools/gen-postmortem-metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@
{ 'name': 'APIObjectType', 'value': 'JS_API_OBJECT_TYPE' },
{ 'name': 'SpecialAPIObjectType', 'value': 'JS_SPECIAL_API_OBJECT_TYPE' },

{ 'name': 'FirstContextType', 'value': 'FIRST_CONTEXT_TYPE' },
{ 'name': 'LastContextType', 'value': 'LAST_CONTEXT_TYPE' },

{ 'name': 'IsNotStringMask', 'value': 'kIsNotStringMask' },
{ 'name': 'StringTag', 'value': 'kStringTag' },

Expand Down Expand Up @@ -289,7 +292,7 @@
expected_classes = [
'ConsString', 'FixedArray', 'HeapNumber', 'JSArray', 'JSFunction',
'JSObject', 'JSRegExp', 'JSValue', 'Map', 'Oddball', 'Script',
'SeqOneByteString', 'SharedFunctionInfo'
'SeqOneByteString', 'SharedFunctionInfo', 'ScopeInfo'
];


Expand Down

0 comments on commit e1dcb79

Please sign in to comment.