From ddd79f78f474a0e81f462edfd77d48922b122112 Mon Sep 17 00:00:00 2001
From: OneNail <onenail@yeah.net>
Date: Sun, 22 May 2022 15:03:42 +0800
Subject: [PATCH] test: improve readline/emitKeypressEvents.js coverage
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PR-URL: https://github.com/nodejs/node/pull/42908
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
---
 .../test-readline-emit-keypress-events.js     | 74 +++++++++++++++----
 1 file changed, 59 insertions(+), 15 deletions(-)

diff --git a/test/parallel/test-readline-emit-keypress-events.js b/test/parallel/test-readline-emit-keypress-events.js
index 8bb10d905cae2a..a9ffd3276c419c 100644
--- a/test/parallel/test-readline-emit-keypress-events.js
+++ b/test/parallel/test-readline-emit-keypress-events.js
@@ -7,22 +7,66 @@ require('../common');
 const assert = require('assert');
 const readline = require('readline');
 const PassThrough = require('stream').PassThrough;
-const stream = new PassThrough();
-const sequence = [];
-const keys = [];
 
-readline.emitKeypressEvents(stream);
-
-stream.on('keypress', (s, k) => {
-  sequence.push(s);
-  keys.push(k);
-});
-
-stream.write('foo');
-
-assert.deepStrictEqual(sequence, ['f', 'o', 'o']);
-assert.deepStrictEqual(keys, [
+const expectedSequence = ['f', 'o', 'o'];
+const expectedKeys = [
   { sequence: 'f', name: 'f', ctrl: false, meta: false, shift: false },
   { sequence: 'o', name: 'o', ctrl: false, meta: false, shift: false },
   { sequence: 'o', name: 'o', ctrl: false, meta: false, shift: false },
-]);
+];
+
+{
+  const stream = new PassThrough();
+  const sequence = [];
+  const keys = [];
+
+  readline.emitKeypressEvents(stream);
+  stream.on('keypress', (s, k) => {
+    sequence.push(s);
+    keys.push(k);
+  });
+  stream.write('foo');
+
+  assert.deepStrictEqual(sequence, expectedSequence);
+  assert.deepStrictEqual(keys, expectedKeys);
+}
+
+{
+  const stream = new PassThrough();
+  const sequence = [];
+  const keys = [];
+
+  stream.on('keypress', (s, k) => {
+    sequence.push(s);
+    keys.push(k);
+  });
+  readline.emitKeypressEvents(stream);
+  stream.write('foo');
+
+  assert.deepStrictEqual(sequence, expectedSequence);
+  assert.deepStrictEqual(keys, expectedKeys);
+}
+
+{
+  const stream = new PassThrough();
+  const sequence = [];
+  const keys = [];
+  const keypressListener = (s, k) => {
+    sequence.push(s);
+    keys.push(k);
+  };
+
+  stream.on('keypress', keypressListener);
+  readline.emitKeypressEvents(stream);
+  stream.removeListener('keypress', keypressListener);
+  stream.write('foo');
+
+  assert.deepStrictEqual(sequence, []);
+  assert.deepStrictEqual(keys, []);
+
+  stream.on('keypress', keypressListener);
+  stream.write('foo');
+
+  assert.deepStrictEqual(sequence, expectedSequence);
+  assert.deepStrictEqual(keys, expectedKeys);
+}