From d38ce82756a617aa78b65201441ee5907a871ad8 Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Tue, 18 Sep 2018 12:56:35 -0700
Subject: [PATCH] test: remove common.hasSmallICU
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

common.hasSmallICU is used in only one test and is a one-liner. Move
into the test where it is used to chip away at the `common` monolith.

PR-URL: https://github.com/nodejs/node/pull/22937
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
---
 test/common/README.md              | 5 -----
 test/common/index.js               | 4 +---
 test/parallel/test-icu-data-dir.js | 4 +++-
 3 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/test/common/README.md b/test/common/README.md
index 28d9bd04f0a8b6..009f8247879f69 100644
--- a/test/common/README.md
+++ b/test/common/README.md
@@ -158,11 +158,6 @@ Indicates `hasCrypto` and `crypto` with fips.
 
 Indicates if [internationalization] is supported.
 
-### hasSmallICU
-* [&lt;boolean>]
-
-Indicates `hasIntl` and `small-icu` are supported.
-
 ### hasIPv6
 * [&lt;boolean>]
 
diff --git a/test/common/index.js b/test/common/index.js
index 0da37360bc4aa1..2efec135772c98 100644
--- a/test/common/index.js
+++ b/test/common/index.js
@@ -33,8 +33,7 @@ const { fixturesDir } = require('./fixtures');
 const tmpdir = require('./tmpdir');
 const {
   bits,
-  hasIntl,
-  hasSmallICU
+  hasIntl
 } = process.binding('config');
 
 const noop = () => {};
@@ -712,7 +711,6 @@ module.exports = {
   hasIntl,
   hasCrypto,
   hasIPv6,
-  hasSmallICU,
   hasMultiLocalhost,
   isAIX,
   isAlive,
diff --git a/test/parallel/test-icu-data-dir.js b/test/parallel/test-icu-data-dir.js
index 800e20c48bab03..47c955bc740fb3 100644
--- a/test/parallel/test-icu-data-dir.js
+++ b/test/parallel/test-icu-data-dir.js
@@ -1,7 +1,9 @@
 'use strict';
 const common = require('../common');
 const os = require('os');
-if (!(common.hasIntl && common.hasSmallICU))
+
+const { hasSmallICU } = process.binding('config');
+if (!(common.hasIntl && hasSmallICU))
   common.skip('missing Intl');
 
 const assert = require('assert');