From d2c0250becaa284495bc5434ce376212adecc855 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Fri, 18 Jan 2019 09:38:22 +0100 Subject: [PATCH] test: fix tests after V8 update Adapt to changes in async stack traces and function name inference --- test/message/esm_display_syntax_error.out | 3 ++- test/message/esm_display_syntax_error_import.out | 2 ++ .../esm_display_syntax_error_import_module.out | 2 ++ test/message/esm_display_syntax_error_module.out | 2 +- test/message/events_unhandled_error_nexttick.out | 2 +- test/message/stdin_messages.out | 16 ++++++++-------- .../message/unhandled_promise_trace_warnings.out | 2 +- test/parallel/test-performance-function.js | 4 ++-- test/parallel/test-repl-underscore.js | 3 --- 9 files changed, 19 insertions(+), 17 deletions(-) diff --git a/test/message/esm_display_syntax_error.out b/test/message/esm_display_syntax_error.out index ed2e928eb1742d..1c68ecb952f3e7 100644 --- a/test/message/esm_display_syntax_error.out +++ b/test/message/esm_display_syntax_error.out @@ -3,4 +3,5 @@ file:///*/test/message/esm_display_syntax_error.mjs:3 await async () => 0; ^^^^^ SyntaxError: Unexpected reserved word - at translators.set (internal/modules/esm/translators.js:*:*) + at internal/modules/esm/translators.js:*:* + at async link (internal/modules/esm/module_job.js:*:*) diff --git a/test/message/esm_display_syntax_error_import.out b/test/message/esm_display_syntax_error_import.out index 31ee2b6f4b1157..edbbde9f2d6407 100644 --- a/test/message/esm_display_syntax_error_import.out +++ b/test/message/esm_display_syntax_error_import.out @@ -4,3 +4,5 @@ file:///*/test/message/esm_display_syntax_error_import.mjs:6 ^^^^^^^^ SyntaxError: The requested module '../fixtures/es-module-loaders/module-named-exports' does not provide an export named 'notfound' at ModuleJob._instantiate (internal/modules/esm/module_job.js:*:*) + at async ModuleJob.run (internal/modules/esm/module_job.js:*:*) + at async Loader.import (internal/modules/esm/loader.js:*:*) diff --git a/test/message/esm_display_syntax_error_import_module.out b/test/message/esm_display_syntax_error_import_module.out index b067a77942fa95..0512a9ac777f0a 100644 --- a/test/message/esm_display_syntax_error_import_module.out +++ b/test/message/esm_display_syntax_error_import_module.out @@ -4,3 +4,5 @@ import { foo, notfound } from './module-named-exports'; ^^^^^^^^ SyntaxError: The requested module './module-named-exports' does not provide an export named 'notfound' at ModuleJob._instantiate (internal/modules/esm/module_job.js:*:*) + at async ModuleJob.run (internal/modules/esm/module_job.js:*:*) + at async Loader.import (internal/modules/esm/loader.js:*:*) diff --git a/test/message/esm_display_syntax_error_module.out b/test/message/esm_display_syntax_error_module.out index e636abad9e464b..4e4cbf2ea33f96 100644 --- a/test/message/esm_display_syntax_error_module.out +++ b/test/message/esm_display_syntax_error_module.out @@ -3,4 +3,4 @@ file:///*/test/fixtures/es-module-loaders/syntax-error.mjs:2 await async () => 0; ^^^^^ SyntaxError: Unexpected reserved word - at translators.set (internal/modules/esm/translators.js:*:*) + at internal/modules/esm/translators.js:*:* diff --git a/test/message/events_unhandled_error_nexttick.out b/test/message/events_unhandled_error_nexttick.out index 4132ae9f3bc1be..8b10cd0dc113c5 100644 --- a/test/message/events_unhandled_error_nexttick.out +++ b/test/message/events_unhandled_error_nexttick.out @@ -12,7 +12,7 @@ Error at Function.Module.runMain (internal/modules/cjs/loader.js:*:*) at internal/main/run_main_module.js:*:* Emitted 'error' event at: - at process.nextTick (*events_unhandled_error_nexttick.js:*:*) + at *events_unhandled_error_nexttick.js:*:* at processTicksAndRejections (internal/process/next_tick.js:*:*) at process.runNextTicks [as _tickCallback] (internal/process/next_tick.js:*:*) at Function.Module.runMain (internal/modules/cjs/loader.js:*:*) diff --git a/test/message/stdin_messages.out b/test/message/stdin_messages.out index 837e9017d7f947..d048a0d947d7d2 100644 --- a/test/message/stdin_messages.out +++ b/test/message/stdin_messages.out @@ -10,8 +10,8 @@ SyntaxError: Strict mode code may not include a with statement at Object. ([stdin]-wrapper:*:*) at Module._compile (internal/modules/cjs/loader.js:*:*) at evalScript (internal/process/execution.js:*:*) - at readStdin (internal/main/eval_stdin.js:*:*) - at Socket.process.stdin.on (internal/process/execution.js:*:*) + at internal/main/eval_stdin.js:*:* + at Socket. (internal/process/execution.js:*:*) at Socket.emit (events.js:*:*) at endReadableNT (_stream_readable.js:*:*) 42 @@ -27,8 +27,8 @@ Error: hello at Object. ([stdin]-wrapper:*:*) at Module._compile (internal/modules/cjs/loader.js:*:*) at evalScript (internal/process/execution.js:*:*) - at readStdin (internal/main/eval_stdin.js:*:*) - at Socket.process.stdin.on (internal/process/execution.js:*:*) + at internal/main/eval_stdin.js:*:* + at Socket. (internal/process/execution.js:*:*) at Socket.emit (events.js:*:*) at endReadableNT (_stream_readable.js:*:*) [stdin]:1 @@ -42,8 +42,8 @@ Error: hello at Object. ([stdin]-wrapper:*:*) at Module._compile (internal/modules/cjs/loader.js:*:*) at evalScript (internal/process/execution.js:*:*) - at readStdin (internal/main/eval_stdin.js:*:*) - at Socket.process.stdin.on (internal/process/execution.js:*:*) + at internal/main/eval_stdin.js:*:* + at Socket. (internal/process/execution.js:*:*) at Socket.emit (events.js:*:*) at endReadableNT (_stream_readable.js:*:*) 100 @@ -58,8 +58,8 @@ ReferenceError: y is not defined at Object. ([stdin]-wrapper:*:*) at Module._compile (internal/modules/cjs/loader.js:*:*) at evalScript (internal/process/execution.js:*:*) - at readStdin (internal/main/eval_stdin.js:*:*) - at Socket.process.stdin.on (internal/process/execution.js:*:*) + at internal/main/eval_stdin.js:*:* + at Socket. (internal/process/execution.js:*:*) at Socket.emit (events.js:*:*) at endReadableNT (_stream_readable.js:*:*) diff --git a/test/message/unhandled_promise_trace_warnings.out b/test/message/unhandled_promise_trace_warnings.out index 60c08805f5cd54..2d3646b51a203d 100644 --- a/test/message/unhandled_promise_trace_warnings.out +++ b/test/message/unhandled_promise_trace_warnings.out @@ -35,5 +35,5 @@ at promiseRejectHandler (internal/process/promises.js:*) at Promise.then * at Promise.catch * - at Immediate.setImmediate (*test*message*unhandled_promise_trace_warnings.js:*) + at Immediate. (*test*message*unhandled_promise_trace_warnings.js:*) at * diff --git a/test/parallel/test-performance-function.js b/test/parallel/test-performance-function.js index 98b381e649b203..25e3db639030ba 100644 --- a/test/parallel/test-performance-function.js +++ b/test/parallel/test-performance-function.js @@ -10,13 +10,13 @@ const { { // Intentional non-op. Do not wrap in common.mustCall(); - const n = performance.timerify(() => {}); + const n = performance.timerify(function noop() {}); const obs = new PerformanceObserver(common.mustCall((list) => { const entries = list.getEntries(); const entry = entries[0]; assert(entry); - assert.strictEqual(entry.name, 'performance.timerify'); + assert.strictEqual(entry.name, 'noop'); assert.strictEqual(entry.entryType, 'function'); assert.strictEqual(typeof entry.duration, 'number'); assert.strictEqual(typeof entry.startTime, 'number'); diff --git a/test/parallel/test-repl-underscore.js b/test/parallel/test-repl-underscore.js index cbf62c3b6e0308..16228bd5c40832 100644 --- a/test/parallel/test-repl-underscore.js +++ b/test/parallel/test-repl-underscore.js @@ -195,9 +195,6 @@ function testError() { // The message from the original throw 'Thrown:', 'Error: baz', - /setImmediate/, - /^ at/, - /^ at/, ]; for (const line of lines) { const expected = expectedLines.shift();