From d06a6a81a588a16444c7034f90fd2f8a1d3d5048 Mon Sep 17 00:00:00 2001 From: Sebastian Plesciuc Date: Thu, 20 Apr 2017 21:10:34 +0300 Subject: [PATCH] test: dynamic port in cluster eaddrinuse Removed common.PORT from test-cluster-eaddrinuse to eliminate the possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: https://github.com/nodejs/node/pull/12547 Ref: https://github.com/nodejs/node/issues/12376 Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Santiago Gimeno Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca --- test/parallel/test-cluster-eaddrinuse.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/parallel/test-cluster-eaddrinuse.js b/test/parallel/test-cluster-eaddrinuse.js index 2757ded6db2a0e..bab0fe0d8b09c9 100644 --- a/test/parallel/test-cluster-eaddrinuse.js +++ b/test/parallel/test-cluster-eaddrinuse.js @@ -30,11 +30,12 @@ const fork = require('child_process').fork; const net = require('net'); const id = '' + process.argv[2]; +const port = '' + process.argv[3]; if (id === 'undefined') { const server = net.createServer(common.mustNotCall()); - server.listen(common.PORT, function() { - const worker = fork(__filename, ['worker']); + server.listen(0, function() { + const worker = fork(__filename, ['worker', server.address().port]); worker.on('message', function(msg) { if (msg !== 'stop-listening') return; server.close(function() { @@ -44,14 +45,14 @@ if (id === 'undefined') { }); } else if (id === 'worker') { let server = net.createServer(common.mustNotCall()); - server.listen(common.PORT, common.mustNotCall()); + server.listen(port, common.mustNotCall()); server.on('error', common.mustCall(function(e) { assert(e.code, 'EADDRINUSE'); process.send('stop-listening'); process.once('message', function(msg) { if (msg !== 'stopped-listening') return; server = net.createServer(common.mustNotCall()); - server.listen(common.PORT, common.mustCall(function() { + server.listen(port, common.mustCall(function() { server.close(); })); });