process: add --pending-deprecation to process.binding()

Print a deprecation warning for `process.binding()` when using `--pending-deprecation`. PR-URL: #26500 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
nodejs · Mar 14, 2019 · ceebbfb · ceebbfb
1 parent fdad4d2
commit ceebbfb
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 7 deletions.
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
@@ -2110,9 +2110,12 @@ changes:
   - version: v10.9.0
     pr-url: https://github.com/nodejs/node/pull/22004
     description: Documentation-only deprecation.
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/26500
+    description: Added support for `--pending-deprecation`.
 -->
 
-Type: Documentation-only
+Type: Documentation-only (supports [`--pending-deprecation`][])
 
 `process.binding()` is for use by Node.js internal code only.
 

diff --git a/lib/internal/bootstrap/pre_execution.js b/lib/internal/bootstrap/pre_execution.js
@@ -149,6 +149,12 @@ function initializeDeprecations() {
       value: noBrowserGlobals
     });
   }
+
+  if (pendingDeprecation) {
+    process.binding = deprecate(process.binding,
+                                'process.binding() is deprecated. ' +
+                                'Please use public APIs instead.', 'DEP0111');
+  }
 }
 
 function setupChildProcessIpcChannel() {

diff --git a/test/parallel/test-err-name-deprecation.js b/test/parallel/test-err-name-deprecation.js
@@ -3,11 +3,14 @@ const common = require('../common');
 
 // Flags: --pending-deprecation
 
-common.expectWarning(
-  'DeprecationWarning',
-  'Directly calling process.binding(\'uv\').errname(<val>) is being ' +
-  'deprecated. Please make sure to use util.getSystemErrorName() instead.',
-  'DEP0119'
-);
+common.expectWarning({
+  DeprecationWarning: [
+    ['process.binding() is deprecated. Please use public APIs instead.',
+     'DEP0111'],
+    ['Directly calling process.binding(\'uv\').errname(<val>) is being ' +
+     'deprecated. Please make sure to use util.getSystemErrorName() instead.',
+     'DEP0119']
+  ]
+});
 
 process.binding('uv').errname(-1);