From ce3dcca619e40f6bcce620f2b7750d847a91b5c6 Mon Sep 17 00:00:00 2001 From: Myk Melez Date: Tue, 31 Jan 2017 10:03:53 -0800 Subject: [PATCH] src: update v8_platform.StartInspector signature The call signature of v8_platform.StartInspector needs to be the same whether or not NODE_USE_V8_PLATFORM, otherwise Node will fail to compile if HAVE_INSPECTOR and !NODE_USE_V8_PLATFORM. (cherry picked from commit e619725faada46e2949faee17a4c791d5c7497c1) PR-URL: https://github.com/nodejs/node/pull/11157 Reviewed-By: Ben Noordhuis --- src/node.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node.cc b/src/node.cc index 3c6b9a731dc2b1..2c5540fdb3d00c 100644 --- a/src/node.cc +++ b/src/node.cc @@ -227,7 +227,7 @@ static struct { void PumpMessageLoop(Isolate* isolate) {} void Dispose() {} bool StartInspector(Environment *env, const char* script_path, - int port, bool wait) { + const node::DebugOptions& options) { env->ThrowError("Node compiled with NODE_USE_V8_PLATFORM=0"); return false; // make compiler happy }