From cda0cca2bd7a15d00132a623d2d555b05be688d8 Mon Sep 17 00:00:00 2001 From: toboid Date: Mon, 6 Feb 2017 21:08:34 +0000 Subject: [PATCH] test: improve test-buffer-includes.js * verify error message * use arrow funcs PR-URL: https://github.com/nodejs/node/pull/11203 Backport-PR-URL: https://github.com/nodejs/node/pull/13785 Reviewed-By: Colin Ihrig Reviewed-By: Yuta Hiroto Reviewed-By: Rich Trott Reviewed-By: James M Snell --- test/parallel/test-buffer-includes.js | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/test/parallel/test-buffer-includes.js b/test/parallel/test-buffer-includes.js index 2b65ce41889cdc..5a0a89ba924f0c 100644 --- a/test/parallel/test-buffer-includes.js +++ b/test/parallel/test-buffer-includes.js @@ -273,15 +273,17 @@ for (let lengthIndex = 0; lengthIndex < lengths.length; lengthIndex++) { } } -assert.throws(function() { - b.includes(function() { }); -}); -assert.throws(function() { +const expectedError = + /^TypeError: "val" argument must be string, number or Buffer$/; +assert.throws(() => { + b.includes(() => {}); +}, expectedError); +assert.throws(() => { b.includes({}); -}); -assert.throws(function() { +}, expectedError); +assert.throws(() => { b.includes([]); -}); +}, expectedError); // test truncation of Number arguments to uint8 {