From c9bd0b0c0f4c628db96be990b99676b8acbcafdd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulises=20Gasc=C3=B3n?= Date: Mon, 13 Nov 2023 18:47:27 +0100 Subject: [PATCH] tools: use macOS keychain to notarize the releases PR-URL: https://github.com/nodejs/node/pull/50715 Reviewed-By: Michael Dawson --- tools/osx-notarize.sh | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tools/osx-notarize.sh b/tools/osx-notarize.sh index bd7ae48a8b15c0..292ce5af1d7dc2 100755 --- a/tools/osx-notarize.sh +++ b/tools/osx-notarize.sh @@ -34,15 +34,10 @@ then exit 1 fi -# Submit the package for notarization -# TODO(@ulisesGascon): refactor to use --keychain-profile -# when https://github.com/nodejs/build/issues/3385#issuecomment-1729281269 is ready echo "Submitting node-$pkgid.pkg for notarization..." xcrun notarytool submit \ - --apple-id "$NOTARIZATION_ID" \ - --password "$NOTARIZATION_PASSWORD" \ - --team-id "$NOTARIZATION_TEAM_ID" \ + --keychain-profile "NODE_RELEASE_PROFILE" \ --wait \ "node-$pkgid.pkg"