From c38576e5264db6b522ba3dec0808028c71b9ad09 Mon Sep 17 00:00:00 2001 From: Mihail Bodrov Date: Fri, 9 Feb 2018 02:42:23 +0300 Subject: [PATCH] buffer: simplify check size in assertSize MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/18665 Reviewed-By: Ruben Bridgewater Reviewed-By: Colin Ihrig Reviewed-By: Michaƫl Zasso Reviewed-By: Joyee Cheung Reviewed-By: Anatoli Papirovski Reviewed-By: James M Snell --- lib/buffer.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/buffer.js b/lib/buffer.js index 91b30012ef65d5..95d41206c67142 100644 --- a/lib/buffer.js +++ b/lib/buffer.js @@ -237,9 +237,7 @@ function assertSize(size) { if (typeof size !== 'number') { err = new errors.TypeError('ERR_INVALID_ARG_TYPE', 'size', 'number', size); - } else if (size < 0) { - err = new errors.RangeError('ERR_INVALID_OPT_VALUE', 'size', size); - } else if (size > kMaxLength) { + } else if (size < 0 || size > kMaxLength) { err = new errors.RangeError('ERR_INVALID_OPT_VALUE', 'size', size); }