From c1bb88699058011cce8df12a5cf39354666f6ab2 Mon Sep 17 00:00:00 2001
From: Alexis Campailla <alexis@janeasystems.com>
Date: Thu, 16 Jan 2014 04:17:01 -0800
Subject: [PATCH] test: remove invalid part of stream2-stderr-sync

One test case in test-stream2-stderr-sync.js was creating a TTY
object using an undocumented constructor and passing in fd 2.
However, this is running in a child process and fd 2 is actually
a pipe, not a TTY.

The constructor fails on Windows and causes the handle type to be
left uninitialized, which later causes an assert to fail.

On Unix, the constructor fails to retrieve the windows size but unlike
on Windows, it just leaves the size fields undefined and continues
with initializing the stream type, yielding a semi-usable object.

I could make the Windows version match Unix behavior, but it
seems to me that the test is relying on an implementation detail of
an undocumented API, and the Unix behavior is not necessarily more
correct than the Windows one. Thus it makes more sense to remove this
test.
---
 test/simple/test-stream2-stderr-sync.js | 62 +++++--------------------
 1 file changed, 11 insertions(+), 51 deletions(-)

diff --git a/test/simple/test-stream2-stderr-sync.js b/test/simple/test-stream2-stderr-sync.js
index efcb50546ae3dc..9e41ac7f03e7bd 100644
--- a/test/simple/test-stream2-stderr-sync.js
+++ b/test/simple/test-stream2-stderr-sync.js
@@ -48,82 +48,42 @@ function parent() {
   });
 }
 
-function child0() {
-  // Just a very simple wrapper around TTY(2)
-  // Essentially the same as stderr, but without all the net stuff.
-  var Writable = require('stream').Writable;
-  var util = require('util');
-
-  // a lowlevel stderr writer
-  var TTY = process.binding('tty_wrap').TTY;
-  var handle = new TTY(2, false);
-
-  util.inherits(W, Writable);
-
-  function W(opts) {
-    Writable.call(this, opts);
-  }
-
-  W.prototype._write = function(chunk, encoding, cb) {
-    var req = { oncomplete: afterWrite };
-    var err = handle.writeUtf8String(req, chunk.toString() + '\n');
-    if (err) throw errnoException(err, 'write');
-    // here's the problem.
-    // it needs to tell the Writable machinery that it's ok to write
-    // more, but that the current buffer length is handle.writeQueueSize
-    if (req.writeQueueSize === 0)
-      req.cb = cb;
-    else
-      cb();
-  }
-  function afterWrite(status, handle, req) {
-    if (req.cb)
-      req.cb();
-  }
-
-  var w = new W
-  w.write('child 0');
-  w.write('foo');
-  w.write('bar');
-  w.write('baz');
-}
-
 // using console.error
-function child1() {
-  console.error('child 1');
+function child0() {
+  console.error('child 0');
   console.error('foo');
   console.error('bar');
   console.error('baz');
 }
 
 // using process.stderr
-function child2() {
-  process.stderr.write('child 2\n');
+function child1() {
+  process.stderr.write('child 1\n');
   process.stderr.write('foo\n');
   process.stderr.write('bar\n');
   process.stderr.write('baz\n');
 }
 
 // using a net socket
-function child3() {
+function child2() {
   var net = require('net');
   var socket = new net.Socket({ fd: 2 });
-  socket.write('child 3\n');
+  socket.write('child 2\n');
   socket.write('foo\n');
   socket.write('bar\n');
   socket.write('baz\n');
 }
 
 
-function child4() {
-  console.error('child 4\nfoo\nbar\nbaz');
+function child3() {
+  console.error('child 3\nfoo\nbar\nbaz');
 }
 
-function child5() {
-  process.stderr.write('child 5\nfoo\nbar\nbaz\n');
+function child4() {
+  process.stderr.write('child 4\nfoo\nbar\nbaz\n');
 }
 
-var children = [ child0, child1, child2, child3, child4, child5 ];
+var children = [ child0, child1, child2, child3, child4 ];
 
 if (!process.argv[2]) {
   parent();