From bd9109c24165109a1d0585790f3ed963506d8ef3 Mon Sep 17 00:00:00 2001 From: cjihrig Date: Sun, 7 Apr 2019 22:22:35 -0400 Subject: [PATCH] lib: move DEP0021 to end of life Server.listenFD() has been runtime deprecated since Node 0.7.12. This commit moves the deprecation to end-of-life. PR-URL: https://github.com/nodejs/node/pull/27127 Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Matteo Collina Reviewed-By: Joyee Cheung --- doc/api/deprecations.md | 7 +++++-- lib/net.js | 6 ------ 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 13ad8efbad11b5..076047ace6f2ad 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -483,6 +483,9 @@ The [`Server.connections`][] property is deprecated. Please use the ### DEP0021: Server.listenFD -Type: Runtime +Type: End-of-Life -The `Server.listenFD()` method is deprecated. Please use +The `Server.listenFD()` method was deprecated and removed. Please use [`Server.listen({fd: })`][] instead. diff --git a/lib/net.js b/lib/net.js index 99d3fc2ed7b6bf..86505a9a4510a5 100644 --- a/lib/net.js +++ b/lib/net.js @@ -1590,12 +1590,6 @@ Object.defineProperty(Socket.prototype, '_handle', { set(v) { return this[kHandle] = v; } }); - -Server.prototype.listenFD = deprecate(function(fd, type) { - return this.listen({ fd: fd }); -}, 'Server.listenFD is deprecated. Use Server.listen({fd: }) instead.', - 'DEP0021'); - Server.prototype._setupWorker = function(socketList) { this._usingWorkers = true; this._workers.push(socketList);