From bd8574cceefca58baee551f1983ebc752e39cfbf Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Sat, 24 Jun 2017 20:11:43 -0700
Subject: [PATCH] test: refactor test-child-process-send-type-error

* Add exit listener to child process to check return code. Previously,
  child process faiilure would not cause the test to fail.
* Use common.mustNotCall() to guarantee callback is not invoked.
* Insert blank line per test writing guide.

PR-URL: https://github.com/nodejs/node/pull/13904
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
---
 .../parallel/test-child-process-send-type-error.js | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/test/parallel/test-child-process-send-type-error.js b/test/parallel/test-child-process-send-type-error.js
index b92d1ee90bffaf..0cff911dc98e49 100644
--- a/test/parallel/test-child-process-send-type-error.js
+++ b/test/parallel/test-child-process-send-type-error.js
@@ -1,10 +1,9 @@
 'use strict';
-require('../common');
+const common = require('../common');
+
 const assert = require('assert');
 const cp = require('child_process');
 
-function noop() {}
-
 function fail(proc, args) {
   assert.throws(() => {
     proc.send.apply(proc, args);
@@ -13,8 +12,13 @@ function fail(proc, args) {
 
 let target = process;
 
-if (process.argv[2] !== 'child')
+if (process.argv[2] !== 'child') {
   target = cp.fork(__filename, ['child']);
+  target.on('exit', common.mustCall((code, signal) => {
+    assert.strictEqual(code, 0);
+    assert.strictEqual(signal, null);
+  }));
+}
 
 fail(target, ['msg', null, null]);
 fail(target, ['msg', null, '']);
@@ -22,4 +26,4 @@ fail(target, ['msg', null, 'foo']);
 fail(target, ['msg', null, 0]);
 fail(target, ['msg', null, NaN]);
 fail(target, ['msg', null, 1]);
-fail(target, ['msg', null, null, noop]);
+fail(target, ['msg', null, null, common.mustNotCall()]);