From bd2e52109652ee7b0fb84fa8ead462a03048df53 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Mon, 23 Apr 2018 11:16:45 +0200 Subject: [PATCH] src: rename return var in VerifySpkac functions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit renames the verification result variable, that is currently named i, to verify_result. PR-URL: https://github.com/nodejs/node/pull/20218 Reviewed-By: Anna Henningsen Reviewed-By: Joyee Cheung Reviewed-By: Richard Lau Reviewed-By: Michaƫl Zasso Reviewed-By: Minwoo Jung Reviewed-By: Colin Ihrig Reviewed-By: James M Snell --- src/node_crypto.cc | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/node_crypto.cc b/src/node_crypto.cc index 970ec04f14530a..8595dc6fb83058 100644 --- a/src/node_crypto.cc +++ b/src/node_crypto.cc @@ -5148,7 +5148,7 @@ void GetCurves(const FunctionCallbackInfo& args) { bool VerifySpkac(const char* data, unsigned int len) { - bool i = false; + bool verify_result = false; EVP_PKEY* pkey = nullptr; NETSCAPE_SPKI* spki = nullptr; @@ -5160,7 +5160,7 @@ bool VerifySpkac(const char* data, unsigned int len) { if (pkey == nullptr) goto exit; - i = NETSCAPE_SPKI_verify(spki, pkey) > 0; + verify_result = NETSCAPE_SPKI_verify(spki, pkey) > 0; exit: if (pkey != nullptr) @@ -5169,23 +5169,23 @@ bool VerifySpkac(const char* data, unsigned int len) { if (spki != nullptr) NETSCAPE_SPKI_free(spki); - return i; + return verify_result; } void VerifySpkac(const FunctionCallbackInfo& args) { - bool i = false; + bool verify_result = false; size_t length = Buffer::Length(args[0]); if (length == 0) - return args.GetReturnValue().Set(i); + return args.GetReturnValue().Set(verify_result); char* data = Buffer::Data(args[0]); CHECK_NE(data, nullptr); - i = VerifySpkac(data, length); + verify_result = VerifySpkac(data, length); - args.GetReturnValue().Set(i); + args.GetReturnValue().Set(verify_result); }