From bb774b1554ed7ad7e7b6d588ef5002382afb8183 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Wed, 23 Jan 2019 00:59:25 +0100 Subject: [PATCH] report: do not use `uv_default_loop()` as fallback Not seeing an associated `Environment` is a rare condition anyway, but using `uv_default_loop()` as a fallback is not thread-safe. PR-URL: https://github.com/nodejs/node/pull/25652 Reviewed-By: Colin Ihrig Reviewed-By: Gireesh Punathil --- src/node_report.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/node_report.cc b/src/node_report.cc index db269903e040ff..0978d32d9078a3 100644 --- a/src/node_report.cc +++ b/src/node_report.cc @@ -307,8 +307,6 @@ static void WriteNodeReport(Isolate* isolate, writer.json_arraystart("libuv"); if (env != nullptr) uv_walk(env->event_loop(), WalkHandle, static_cast(&writer)); - else - uv_walk(uv_default_loop(), WalkHandle, static_cast(&writer)); writer.json_arrayend();