From b6d33f671a452b1aebcc09adf4c3b9dba29da3c7 Mon Sep 17 00:00:00 2001
From: Rusty Conover <rusty@conover.me>
Date: Tue, 25 Feb 2020 23:12:51 -0500
Subject: [PATCH] test: change test to not be sensitive to buffer send size

Change the test to not be sensitive to the buffer size causing
TCP resets to be received by the client causing the test to fail.
The test now reads the entire expected buffer and then checks for
the expected event to fire.

PR-URL: https://github.com/nodejs/node/pull/31499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 .../test-tls-close-event-after-write.js         | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/test/parallel/test-tls-close-event-after-write.js b/test/parallel/test-tls-close-event-after-write.js
index 31ebc897b14758..57c79e2e5ab72d 100644
--- a/test/parallel/test-tls-close-event-after-write.js
+++ b/test/parallel/test-tls-close-event-after-write.js
@@ -12,23 +12,22 @@ const tls = require('tls');
 const fixtures = require('../common/fixtures');
 let cconn = null;
 let sconn = null;
+let read_len = 0;
+const buffer_size = 1024 * 1024;
 
 function test() {
   if (cconn && sconn) {
     cconn.resume();
     sconn.resume();
-    sconn.end(Buffer.alloc(1024 * 1024));
-    cconn.end();
+    sconn.end(Buffer.alloc(buffer_size));
   }
 }
 
 const server = tls.createServer({
   key: fixtures.readKey('agent1-key.pem'),
   cert: fixtures.readKey('agent1-cert.pem')
-}, function(c) {
-  c.on('close', function() {
-    server.close();
-  });
+}, (c) => {
+  c.on('close', common.mustCall(() => server.close()));
   sconn = c;
   test();
 }).listen(0, common.mustCall(function() {
@@ -36,6 +35,12 @@ const server = tls.createServer({
     rejectUnauthorized: false
   }, common.mustCall(function() {
     cconn = this;
+    cconn.on('data', (d) => {
+      read_len += d.length;
+      if (read_len === buffer_size) {
+        cconn.end();
+      }
+    });
     test();
   }));
 }));