From b64b22377c6d1744b162cff0a0dae49a8dcf0637 Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Sat, 30 Mar 2019 13:07:06 -0400 Subject: [PATCH] build,win: silence MSVC warning C4129 for V8 Currently we get 13,799 of those per build PR-URL: https://github.com/nodejs/node/pull/27017 Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Ruben Bridgewater Signed-off-by: Beth Griggs --- deps/v8/gypfiles/toolchain.gypi | 1 + 1 file changed, 1 insertion(+) diff --git a/deps/v8/gypfiles/toolchain.gypi b/deps/v8/gypfiles/toolchain.gypi index 6da48e2282207c..f488461a00412b 100644 --- a/deps/v8/gypfiles/toolchain.gypi +++ b/deps/v8/gypfiles/toolchain.gypi @@ -1395,6 +1395,7 @@ }, # configurations 'cflags': [ '-Wno-type-limits', ], 'msvs_disabled_warnings': [ + 4129, # unrecognized character escape sequence (torque-generated) 4245, # Conversion with signed/unsigned mismatch. 4267, # Conversion with possible loss of data. 4324, # Padding structure due to alignment.