Skip to content

Commit

Permalink
deps: V8: backport a11395433dbd
Browse files Browse the repository at this point in the history
Original commit message:

    [cppgc]: Fix build on msvc

    Fixes compilation with msvc 2019 toolchain.

    See: #37330 (comment)
    Change-Id: I3b658d9ef49889c0a0467a1146e8d16b50fca65d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2711152
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72917}

Refs: v8/v8@a113954

PR-URL: #37330
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
targos committed Feb 24, 2021
1 parent d6b5061 commit b186142
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.13',
'v8_embedder_string': '-node.14',

##### V8 defaults for Node.js #####

Expand Down
3 changes: 3 additions & 0 deletions deps/v8/include/v8-cppgc.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ class CppHeap;
} // namespace internal

struct V8_EXPORT CppHeapCreateParams {
CppHeapCreateParams(const CppHeapCreateParams&) = delete;
CppHeapCreateParams& operator=(const CppHeapCreateParams&) = delete;

std::vector<std::unique_ptr<cppgc::CustomSpaceBase>> custom_spaces;
};

Expand Down

0 comments on commit b186142

Please sign in to comment.