From 9ab648120c7b226976ba2dfc6a89fda06e09addb Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Sun, 22 Oct 2017 10:43:05 -0400 Subject: [PATCH] build: improve `make clean` also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: https://github.com/nodejs/node/pull/16372 Refs: https://github.com/nodejs/node/pull/16010 Refs: https://github.com/nodejs/node/issues/16278 Reviewed-By: Rich Trott Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca Reviewed-By: Gibson Fahnestock Reviewed-By: James M Snell --- Makefile | 6 +++++- vcbuild.bat | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index fccf6451cc5a63..4e974903a93ebd 100644 --- a/Makefile +++ b/Makefile @@ -102,11 +102,15 @@ uninstall: clean: $(RM) -r out/Makefile $(NODE_EXE) $(NODE_G_EXE) out/$(BUILDTYPE)/$(NODE_EXE) \ - out/$(BUILDTYPE)/node.exp + out/$(BUILDTYPE)/node.exp @if [ -d out ]; then find out/ -name '*.o' -o -name '*.a' -o -name '*.d' | xargs $(RM) -r; fi $(RM) -r node_modules @if [ -d deps/icu ]; then echo deleting deps/icu; $(RM) -r deps/icu; fi $(RM) test.tap + # Next one is legacy remove this at some point + $(RM) -r test/tmp* + $(RM) -r test/.tmp* + $(MAKE) test-addons-clean distclean: $(RM) -r out diff --git a/vcbuild.bat b/vcbuild.bat index 4d315ad3ff984e..7db343d8747a21 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -541,7 +541,7 @@ echo Failed to create vc project files. goto exit :help -echo vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/test-internet/test-pummel/test-simple/test-message/test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/test-v8-all] [clean] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module] +echo vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/test-internet/test-pummel/test-simple/test-message/test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/test-v8-all] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module] echo Examples: echo vcbuild.bat : builds release build echo vcbuild.bat debug : builds debug build