Skip to content

Commit

Permalink
src: avoid using elevated v8 namespaces in node_errors.h
Browse files Browse the repository at this point in the history
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #32468
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
jasnell authored and targos committed Apr 11, 2020
1 parent 97a3e2f commit 9600332
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions src/node_errors.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,10 @@

namespace node {

using v8::Local;
using v8::Message;
using v8::Value;

enum ErrorHandlingMode { CONTEXTIFY_ERROR, FATAL_ERROR, MODULE_ERROR };
void AppendExceptionLine(Environment* env,
Local<Value> er,
Local<Message> message,
v8::Local<v8::Value> er,
v8::Local<v8::Message> message,
enum ErrorHandlingMode mode);

[[noreturn]] void FatalError(const char* location, const char* message);
Expand Down Expand Up @@ -195,8 +191,8 @@ class TryCatchScope : public v8::TryCatch {
void TriggerUncaughtException(v8::Isolate* isolate,
const v8::TryCatch& try_catch);
void TriggerUncaughtException(v8::Isolate* isolate,
Local<Value> error,
Local<Message> message,
v8::Local<v8::Value> error,
v8::Local<v8::Message> message,
bool from_promise = false);

const char* errno_string(int errorno);
Expand Down

0 comments on commit 9600332

Please sign in to comment.