lib,test: fix error message check after V8 update

Backport-PR-URL: #29241 PR-URL: #28918 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs · Sep 19, 2019 · 91d99ce · 91d99ce
1 parent 027dcff
commit 91d99ce
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js
@@ -97,7 +97,7 @@ function enrichCJSError(err) {
     usage. However, some cases are not matching, cases like import statement
     after a comment block and/or after a variable definition.
   */
-  if (err.message.startsWith('Unexpected token export') ||
+  if (err.message.startsWith('Unexpected token \'export\'') ||
     (/^\s*import(?=[ {'"*])\s*(?![ (])/).test(lineWithErr)) {
     process.emitWarning(
       'To load an ES module, set "type": "module" in the package.json or use ' +

diff --git a/test/parallel/test-v8-flags.js b/test/parallel/test-v8-flags.js
@@ -13,6 +13,6 @@ assert(vm.runInThisContext('%_IsSmi(43)'));
 
 v8.setFlagsFromString('--noallow_natives_syntax');
 assert.throws(function() { eval('%_IsSmi(44)'); },
-              /^SyntaxError: Unexpected token %$/);
+              /^SyntaxError: Unexpected token '%'$/);
 assert.throws(function() { vm.runInThisContext('%_IsSmi(45)'); },
-              /^SyntaxError: Unexpected token %$/);
+              /^SyntaxError: Unexpected token '%'$/);
diff --git a/test/parallel/test-vm-basic.js b/test/parallel/test-vm-basic.js
@@ -152,7 +152,7 @@ const vm = require('vm');
     );
   }, {
     type: SyntaxError,
-    message: 'Unexpected token }'
+    message: "Unexpected token '}'"
   });
 
   // Tests for failed argument validation