Skip to content

Commit

Permalink
test: mark test-net-error-twice flaky on SmartOS
Browse files Browse the repository at this point in the history
It seems that test-net-error-twice.js does not behave as expected. Its
goal is to test fireErrorCallbacks, but it doesn't do it correctly,
leading to false negatives on some platforms and failures on others.
This change marks this test as flaky so that we can use our CI to land
changes in the v0.10 branch until we can fix it properly.

See the corresponding issue at
nodejs/node-v0.x-archive#9325 for more details.

PR: #25760
PR-URL: nodejs/node-v0.x-archive#25760
Reviewed-By: João Reis <reis@janeasystems.com>
  • Loading branch information
Julien Gilli committed Jul 23, 2015
1 parent e10892c commit 7df5770
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions test/simple/simple.status
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ test-debugger-repl : PASS,FLAKY
test-debugger-repl-break-in-module : PASS,FLAKY
test-debugger-repl-utf8 : PASS,FLAKY
test-net-server-max-connections : PASS,FLAKY
test-net-error-twice : PASS,FLAKY

0 comments on commit 7df5770

Please sign in to comment.