Skip to content

Commit

Permalink
crypto: don't call SSL_CTX_set_ciphersuites on boringssl
Browse files Browse the repository at this point in the history
PR-URL: #26365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
nornagon authored and BridgeAR committed Mar 12, 2019
1 parent f99349d commit 7155aaf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/node_crypto.cc
Original file line number Diff line number Diff line change
Expand Up @@ -937,7 +937,7 @@ void SecureContext::SetCiphers(const FunctionCallbackInfo<Value>& args) {
// TLSv1.3 cipher suites, so we get backwards compatible synchronous errors.
const node::Utf8Value ciphers(args.GetIsolate(), args[0]);
if (
#ifdef TLS1_3_VERSION
#if defined(TLS1_3_VERSION) && !defined(OPENSSL_IS_BORINGSSL)
!SSL_CTX_set_ciphersuites(sc->ctx_.get(), "") ||
#endif
!SSL_CTX_set_cipher_list(sc->ctx_.get(), *ciphers)) {
Expand Down

0 comments on commit 7155aaf

Please sign in to comment.