From 68e8c9a607586271a7e406a8876add79b9db8cc6 Mon Sep 17 00:00:00 2001 From: treysis Date: Sun, 5 Sep 2021 21:09:15 +0200 Subject: [PATCH] dns: trying to fix test-net-remote-address-port.js PR-URL: https://github.com/nodejs/node/pull/39987 Fixes: https://github.com/nodejs/node/issues/31566 Refs: https://github.com/nodejs/node/issues/6307 Refs: https://github.com/nodejs/node/pull/20710 Refs: https://github.com/nodejs/node/pull/38099 Reviewed-By: Antoine du Hamel Reviewed-By: Matteo Collina Reviewed-By: James M Snell Reviewed-By: Michael Dawson --- test/parallel/test-net-remote-address-port.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/test/parallel/test-net-remote-address-port.js b/test/parallel/test-net-remote-address-port.js index fe090a3aa7a580..799841584def56 100644 --- a/test/parallel/test-net-remote-address-port.js +++ b/test/parallel/test-net-remote-address-port.js @@ -34,11 +34,13 @@ const remoteFamilyCandidates = ['IPv4']; if (common.hasIPv6) remoteFamilyCandidates.push('IPv6'); const server = net.createServer(common.mustCall(function(socket) { - // Test to see real value in CI log - assert.match(socket.remoteAddress, - /^127\.0\.0\.1$|^::1$|^::ffff:127\.0\.0\.1$/); - // REM: assert.ok(remoteAddrCandidates.includes(socket.remoteAddress)); - assert.ok(remoteFamilyCandidates.includes(socket.remoteFamily)); + // REM: assert.match(socket.remoteAddress, + // REM: /^127\.0\.0\.1$|^::1$|^::ffff:127\.0\.0\.1$/); + assert.ok(remoteAddrCandidates.includes(socket.remoteAddress), + `Illformed remoteAddress: ${socket.remoteAddress}`); + assert.ok(remoteFamilyCandidates.includes(socket.remoteFamily), + `Illformed remoteFamily: ${socket.remoteFamily}`); + // REM: assert.ok(remoteFamilyCandidates.includes(socket.remoteFamily)); assert.ok(socket.remotePort); assert.notStrictEqual(socket.remotePort, this.address().port); socket.on('end', function() {