From 614298d0113aa5b9783a12dd9adba6023954bf9b Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 5 Aug 2020 22:03:54 -0700 Subject: [PATCH] repl: use _REPL_ in user-facing text MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit User-facing error messages should use _REPL_ for the general REPL and not _repl_ which should be reserved for referring to the module itself, etc. _REPL_ is an acronym, so it should be capitalized, as it generally is in documentation in other technologies, and is usually in our own documentation. This fixes a few inconsistent usages in lib/repl.js. PR-URL: https://github.com/nodejs/node/pull/34643 Reviewed-By: Michaƫl Zasso Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Luigi Pinca Reviewed-By: James M Snell Reviewed-By: Trivikram Kamat --- lib/repl.js | 10 +++++----- test/parallel/test-repl.js | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/repl.js b/lib/repl.js index b881a17936b3b0..b2c0e3aa1bc360 100644 --- a/lib/repl.js +++ b/lib/repl.js @@ -19,7 +19,7 @@ // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE // USE OR OTHER DEALINGS IN THE SOFTWARE. -/* A repl library that you can include in your own code to get a runtime +/* A REPL library that you can include in your own code to get a runtime * interface to your program. * * const repl = require("repl"); @@ -581,7 +581,7 @@ function REPLServer(prompt, 'module'; if (StringPrototypeIncludes(e.message, importErrorStr)) { e.message = 'Cannot use import statement inside the Node.js ' + - 'repl, alternatively use dynamic import'; + 'REPL, alternatively use dynamic import'; e.stack = e.stack.replace(/SyntaxError:.*\n/, `SyntaxError: ${e.message}\n`); } @@ -790,7 +790,7 @@ function REPLServer(prompt, if (e && !self[kBufferedCommandSymbol] && cmd.trim().startsWith('npm ')) { self.output.write('npm should be run outside of the ' + - 'node repl, in your normal shell.\n' + + 'node REPL, in your normal shell.\n' + '(Press Control-D to exit.)\n'); self.displayPrompt(); return; @@ -1487,7 +1487,7 @@ function defineDefaultCommands(repl) { }); repl.defineCommand('exit', { - help: 'Exit the repl', + help: 'Exit the REPL', action: function() { this.close(); } @@ -1509,7 +1509,7 @@ function defineDefaultCommands(repl) { this.output.write(line); } this.output.write('\nPress ^C to abort current expression, ' + - '^D to exit the repl\n'); + '^D to exit the REPL\n'); this.displayPrompt(); } }); diff --git a/test/parallel/test-repl.js b/test/parallel/test-repl.js index 8f98dfd540ace8..8d473637bfd436 100644 --- a/test/parallel/test-repl.js +++ b/test/parallel/test-repl.js @@ -372,7 +372,7 @@ const errorTests = [ { send: 'npm install foobar', expect: [ - 'npm should be run outside of the node repl, in your normal shell.', + 'npm should be run outside of the node REPL, in your normal shell.', '(Press Control-D to exit.)' ] }, @@ -453,7 +453,7 @@ const errorTests = [ /\.load/, /\.save/, '', - 'Press ^C to abort current expression, ^D to exit the repl', + 'Press ^C to abort current expression, ^D to exit the REPL', /'thefourtheye'/ ] },