From 5e138fe768f2cef2273f27cf72d8b7e156726d88 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Sun, 23 Oct 2016 08:08:39 -0700 Subject: [PATCH] test: skip whatwg url parse and setter tests when icu is missing MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit the WHATWG url parser relies on ICU's punycode implementation. A handful of the standard tests fail when ICU is not present because of the additional checks that are not implemented. For now, skip the parse and setter tests if ICU is not present. PR-URL: https://github.com/nodejs/node/pull/9246 Reviewed-By: Michael Dawson Reviewed-By: Roman Reiss Reviewed-By: Johan Bergström Reviewed-By: Ben Noordhuis --- test/parallel/test-whatwg-url-parsing.js | 7 +++++++ test/parallel/test-whatwg-url-setters.js | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/test/parallel/test-whatwg-url-parsing.js b/test/parallel/test-whatwg-url-parsing.js index 568bc821758dd5..40ada010c1dd36 100644 --- a/test/parallel/test-whatwg-url-parsing.js +++ b/test/parallel/test-whatwg-url-parsing.js @@ -1,6 +1,13 @@ 'use strict'; const common = require('../common'); + +if (!common.hasIntl) { + // A handful of the tests fail when ICU is not included. + common.skip('missing Intl... skipping test'); + return; +} + const URL = require('url').URL; const path = require('path'); const assert = require('assert'); diff --git a/test/parallel/test-whatwg-url-setters.js b/test/parallel/test-whatwg-url-setters.js index 4c29ef098cc463..3b2aca2afd89d7 100644 --- a/test/parallel/test-whatwg-url-setters.js +++ b/test/parallel/test-whatwg-url-setters.js @@ -1,6 +1,13 @@ 'use strict'; const common = require('../common'); + +if (!common.hasIntl) { + // A handful of the tests fail when ICU is not included. + common.skip('missing Intl... skipping test'); + return; +} + const path = require('path'); const URL = require('url').URL; const assert = require('assert');