From 5dd3395377c9a20366af5486c6791feefeea38e3 Mon Sep 17 00:00:00 2001
From: atlowChemi <chemi@testim.io>
Date: Sun, 25 Jun 2023 23:29:58 +0300
Subject: [PATCH] https: server add `asyncDispose`

PR-URL: https://github.com/nodejs/node/pull/48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
---
 doc/api/https.md                              | 12 ++++++++++++
 lib/https.js                                  |  6 ++++++
 .../test-https-server-async-dispose.js        | 19 +++++++++++++++++++
 3 files changed, 37 insertions(+)
 create mode 100644 test/parallel/test-https-server-async-dispose.js

diff --git a/doc/api/https.md b/doc/api/https.md
index c4dbd898613d6f..c511d8107ff0d4 100644
--- a/doc/api/https.md
+++ b/doc/api/https.md
@@ -135,6 +135,17 @@ added: v0.1.90
 
 See [`server.close()`][] in the `node:http` module.
 
+### `server[Symbol.asyncDispose]()`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+> Stability: 1 - Experimental
+
+Calls [`server.close()`][httpsServerClose] and returns a promise that
+fulfills when the server has closed.
+
 ### `server.closeAllConnections()`
 
 <!-- YAML
@@ -571,4 +582,5 @@ headers: max-age=0; pin-sha256="WoiWRyIOVNa9ihaBciRSC7XHjliYS9VwUGOIud4PB18="; p
 [`tls.connect()`]: tls.md#tlsconnectoptions-callback
 [`tls.createSecureContext()`]: tls.md#tlscreatesecurecontextoptions
 [`tls.createServer()`]: tls.md#tlscreateserveroptions-secureconnectionlistener
+[httpsServerClose]: #serverclosecallback
 [sni wiki]: https://en.wikipedia.org/wiki/Server_Name_Indication
diff --git a/lib/https.js b/lib/https.js
index ca695555640a32..d8b42c85493f7e 100644
--- a/lib/https.js
+++ b/lib/https.js
@@ -33,11 +33,13 @@ const {
   ObjectSetPrototypeOf,
   ReflectApply,
   ReflectConstruct,
+  SymbolAsyncDispose,
 } = primordials;
 
 const {
   assertCrypto,
   kEmptyObject,
+  promisify,
 } = require('internal/util');
 assertCrypto();
 
@@ -110,6 +112,10 @@ Server.prototype.close = function() {
   ReflectApply(tls.Server.prototype.close, this, arguments);
 };
 
+Server.prototype[SymbolAsyncDispose] = async function() {
+  return FunctionPrototypeCall(promisify(this.close), this);
+};
+
 /**
  * Creates a new `https.Server` instance.
  * @param {{
diff --git a/test/parallel/test-https-server-async-dispose.js b/test/parallel/test-https-server-async-dispose.js
new file mode 100644
index 00000000000000..93b5cb74bbda11
--- /dev/null
+++ b/test/parallel/test-https-server-async-dispose.js
@@ -0,0 +1,19 @@
+'use strict';
+
+const common = require('../common');
+
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+
+const assert = require('assert');
+const { createServer } = require('https');
+const { kConnectionsCheckingInterval } = require('_http_server');
+
+const server = createServer();
+
+server.listen(0, common.mustCall(() => {
+  server.on('close', common.mustCall());
+  server[Symbol.asyncDispose]().then(common.mustCall(() => {
+    assert(server[kConnectionsCheckingInterval]._destroyed);
+  }));
+}));