From 59d435ed4dad697a185fdcaf15aff01364dd5dcb Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Mon, 11 May 2020 23:11:33 +0200 Subject: [PATCH] lib: update TODO comments This removes one TODO comment and adds another that indicates that readline is currently not able to trigger specific escape sequences. Signed-off-by: Ruben Bridgewater PR-URL: https://github.com/nodejs/node/pull/33361 Reviewed-By: Anto Aravinth --- lib/readline.js | 6 +++++- test/parallel/test-assert-deep.js | 2 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/readline.js b/lib/readline.js index 4684fe91068b5c..7d44dd2366cf39 100644 --- a/lib/readline.js +++ b/lib/readline.js @@ -855,6 +855,8 @@ Interface.prototype._ttyWrite = function(s, key) { if (key.ctrl && key.shift) { /* Control and shift pressed */ switch (key.name) { + // TODO(BridgeAR): The transmitted escape sequence is `\b` and that is + // identical to -h. It should have a unique escape sequence. case 'backspace': this._deleteLineLeft(); break; @@ -952,8 +954,10 @@ Interface.prototype._ttyWrite = function(s, key) { } break; - // TODO(BridgeAR): This seems broken? case 'w': // Delete backwards to a word boundary + // TODO(BridgeAR): The transmitted escape sequence is `\b` and that is + // identical to -h. It should have a unique escape sequence. + // Falls through case 'backspace': this._deleteWordLeft(); break; diff --git a/test/parallel/test-assert-deep.js b/test/parallel/test-assert-deep.js index 454b1920f00aee..73af4b3e226929 100644 --- a/test/parallel/test-assert-deep.js +++ b/test/parallel/test-assert-deep.js @@ -957,8 +957,6 @@ assertDeepAndStrictEqual(obj1, obj2); // Check proxies. { - // TODO(BridgeAR): Check if it would not be better to detect proxies instead - // of just using the proxy value. const arrProxy = new Proxy([1, 2], {}); assert.deepStrictEqual(arrProxy, [1, 2]); const tmp = util.inspect.defaultOptions;