From 560a589e75c12cfd2c2813622a70271c962f6e0e Mon Sep 17 00:00:00 2001 From: "Italo A. Casas" Date: Mon, 26 Sep 2016 23:51:19 -0400 Subject: [PATCH] stream: improve stream error messages Improve message when tranform._transform() method is not implemented Improve error message when Readable._read() is not implemented Remove extra word in err msg when Writable._write() when not implemented Remove extra word in err msg when Transform._transform() when not implemented PR-URL: https://github.com/nodejs/node/pull/8801 Reviewed-By: Rich Trott Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Ilkka Myller --- lib/_stream_readable.js | 2 +- lib/_stream_transform.js | 2 +- lib/_stream_writable.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js index 65efdc4992fcef..5b9087a8737581 100644 --- a/lib/_stream_readable.js +++ b/lib/_stream_readable.js @@ -467,7 +467,7 @@ function maybeReadMore_(stream, state) { // for virtual (non-string, non-buffer) streams, "length" is somewhat // arbitrary, and perhaps not very meaningful. Readable.prototype._read = function(n) { - this.emit('error', new Error('not implemented')); + this.emit('error', new Error('_read() is not implemented')); }; Readable.prototype.pipe = function(dest, pipeOpts) { diff --git a/lib/_stream_transform.js b/lib/_stream_transform.js index 5dc7fdd0a8d831..259774c45c7335 100644 --- a/lib/_stream_transform.js +++ b/lib/_stream_transform.js @@ -139,7 +139,7 @@ Transform.prototype.push = function(chunk, encoding) { // an error, then that'll put the hurt on the whole operation. If you // never call cb(), then you'll never get another chunk. Transform.prototype._transform = function(chunk, encoding, cb) { - throw new Error('Not implemented'); + throw new Error('_transform() is not implemented'); }; Transform.prototype._write = function(chunk, encoding, cb) { diff --git a/lib/_stream_writable.js b/lib/_stream_writable.js index 88c19cddbfa490..7a728c9de2c8aa 100644 --- a/lib/_stream_writable.js +++ b/lib/_stream_writable.js @@ -432,7 +432,7 @@ function clearBuffer(stream, state) { } Writable.prototype._write = function(chunk, encoding, cb) { - cb(new Error('_write() method is not implemented')); + cb(new Error('_write() is not implemented')); }; Writable.prototype._writev = null;