From 51bbfb625005b50f339c0be865e1c4ba72f3a507 Mon Sep 17 00:00:00 2001 From: Kunal Pathak Date: Mon, 15 Aug 2016 12:14:22 -0700 Subject: [PATCH] src: fix build break for !NODE_USE_V8_PLATFORM MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `StartInspector` should return `bool` but there was signature mismatch if not building for v8 platform i.e. `!NODE_USE_V8_PLATFORM` PR-URL: nodejs/node#8114 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Michaƫl Zasso --- src/node.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/node.cc b/src/node.cc index 32273319348b70..eb9d3b6cc85b44 100644 --- a/src/node.cc +++ b/src/node.cc @@ -220,8 +220,9 @@ static struct { void Initialize(int thread_pool_size) {} void PumpMessageLoop(Isolate* isolate) {} void Dispose() {} - void StartInspector(Environment *env, int port, bool wait) { + bool StartInspector(Environment *env, int port, bool wait) { env->ThrowError("Node compiled with NODE_USE_V8_PLATFORM=0"); + return false; // make compiler happy } #endif // !NODE_USE_V8_PLATFORM } v8_platform;