crypto: improve error messages

Introduce a new MACRO to check if the data is a String object and update existing MACROs to include the actual object description to be printed in case of an error. PR-URL: #3100 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Mar 26, 2016 · 41feaa8 · 41feaa8
1 parent 8b2e437
commit 41feaa8
Show file tree

Hide file tree

Showing 3 changed files with 180 additions and 104 deletions.
diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
@@ -762,7 +762,7 @@ function Server(/* [options], listener */) {
   var timeout = options.handshakeTimeout || (120 * 1000);
 
   if (typeof timeout !== 'number') {
-    throw new TypeError('"handshakeTimeout" option must be a number');
+    throw new TypeError('handshakeTimeout must be a number');
   }
 
   if (self.sessionTimeout) {