From 40a7b0b993f0331b10f268c7686d02f2a00c2625 Mon Sep 17 00:00:00 2001 From: Deokjin Kim Date: Sat, 11 Mar 2023 00:07:55 +0900 Subject: [PATCH] net: fix setting of value in 'setDefaultAutoSelectFamilyAttemptTimeout' Document describes that the value have to be 10 if passed value to `setDefaultAutoSelectFamilyAttemptTimeout` is less than 10. So need to use 10 for 'if' statement and fix typo in document. Refs: https://github.com/nodejs/node/blob/main/doc/api/net.md#netsetdefaultautoselectfamilyattempttimeoutvalue PR-URL: https://github.com/nodejs/node/pull/47012 Reviewed-By: Paolo Insogna Reviewed-By: Yagiz Nizipli Reviewed-By: Minwoo Jung --- doc/api/net.md | 2 +- lib/net.js | 2 +- ...ocket-connect-invalid-autoselectfamilyattempttimeout.js | 7 +++++++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/doc/api/net.md b/doc/api/net.md index e7ec8f66f57f57..3ea7dff6243196 100644 --- a/doc/api/net.md +++ b/doc/api/net.md @@ -1659,7 +1659,7 @@ added: REPLACEME Sets the default value of the `autoSelectFamilyAttemptTimeout` option of [`socket.connect(options)`][]. * `value` {number} The new default value, which must be a positive number. If the number is less than `10`, - the value `10` is used insted The initial default value is `250`. + the value `10` is used instead. The initial default value is `250`. ## `net.isIP(input)` diff --git a/lib/net.js b/lib/net.js index 9644e6ef2e5aa4..3a4ff0056107a4 100644 --- a/lib/net.js +++ b/lib/net.js @@ -247,7 +247,7 @@ function getDefaultAutoSelectFamilyAttemptTimeout() { function setDefaultAutoSelectFamilyAttemptTimeout(value) { validateInt32(value, 'value', 1); - if (value < 1) { + if (value < 10) { value = 10; } diff --git a/test/parallel/test-net-socket-connect-invalid-autoselectfamilyattempttimeout.js b/test/parallel/test-net-socket-connect-invalid-autoselectfamilyattempttimeout.js index adec8200f697d2..0fc813781c95ec 100644 --- a/test/parallel/test-net-socket-connect-invalid-autoselectfamilyattempttimeout.js +++ b/test/parallel/test-net-socket-connect-invalid-autoselectfamilyattempttimeout.js @@ -18,3 +18,10 @@ for (const autoSelectFamilyAttemptTimeout of [-10, 0]) { net.setDefaultAutoSelectFamilyAttemptTimeout(autoSelectFamilyAttemptTimeout); }, { code: 'ERR_OUT_OF_RANGE' }); } + +// Check the default value of autoSelectFamilyAttemptTimeout is 10 +// if passed number is less than 10 +for (const autoSelectFamilyAttemptTimeout of [1, 9]) { + net.setDefaultAutoSelectFamilyAttemptTimeout(autoSelectFamilyAttemptTimeout); + assert.strictEqual(net.getDefaultAutoSelectFamilyAttemptTimeout(), 10); +}