Skip to content

Commit 3d5e7cd

Browse files
committed
report: fix recent coverity warning
Fix warning about dereferencing null env Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #48954 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent b3eb05b commit 3d5e7cd

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/node_report.cc

+7-3
Original file line numberDiff line numberDiff line change
@@ -857,9 +857,13 @@ std::string TriggerNodeReport(Isolate* isolate,
857857
// Determine the required report filename. In order of priority:
858858
// 1) supplied on API 2) configured on startup 3) default generated
859859
if (!name.empty()) {
860-
THROW_IF_INSUFFICIENT_PERMISSIONS(
861-
env, permission::PermissionScope::kFileSystemWrite, name, name);
862-
// Filename was specified as API parameter.
860+
// we may not always be in a great state when generating a node report
861+
// allow for the case where we don't have an env
862+
if (env != nullptr) {
863+
THROW_IF_INSUFFICIENT_PERMISSIONS(
864+
env, permission::PermissionScope::kFileSystemWrite, name, name);
865+
// Filename was specified as API parameter.
866+
}
863867
filename = name;
864868
} else {
865869
std::string report_filename;

0 commit comments

Comments
 (0)