Skip to content

Commit 3513243

Browse files
cjihrigBethGriggs
authored andcommitted
src: fix -Wsign-compare warnings
This commit addresses the following compilation warnings: ../src/node_crypto.cc:5053:3: warning: comparison of integers of different signs: 'unsigned int' and 'int' [-Wsign-compare] CHECK_EQ(n, BN_bn2binpad(r, data, n)); ../src/node_crypto.cc:5054:3: warning: comparison of integers of different signs: 'unsigned int' and 'int' [-Wsign-compare] CHECK_EQ(n, BN_bn2binpad(s, data + n, n)); PR-URL: #30565 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
1 parent 4f85f52 commit 3513243

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/node_crypto.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -5050,8 +5050,8 @@ static AllocatedBuffer ConvertSignatureToP1363(Environment* env,
50505050

50515051
const BIGNUM* r = ECDSA_SIG_get0_r(asn1_sig);
50525052
const BIGNUM* s = ECDSA_SIG_get0_s(asn1_sig);
5053-
CHECK_EQ(n, BN_bn2binpad(r, data, n));
5054-
CHECK_EQ(n, BN_bn2binpad(s, data + n, n));
5053+
CHECK_EQ(n, static_cast<unsigned int>(BN_bn2binpad(r, data, n)));
5054+
CHECK_EQ(n, static_cast<unsigned int>(BN_bn2binpad(s, data + n, n)));
50555055

50565056
ECDSA_SIG_free(asn1_sig);
50575057

0 commit comments

Comments
 (0)