From 340c06ae740ee59b676ddb545dfaaf04b0dd683c Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 24 Jul 2017 12:54:30 -0700 Subject: [PATCH] squash: comments per refack nits --- test/parallel/test-http-set-timeout-server.js | 2 ++ test/parallel/test-https-set-timeout-server.js | 3 +++ 2 files changed, 5 insertions(+) diff --git a/test/parallel/test-http-set-timeout-server.js b/test/parallel/test-http-set-timeout-server.js index c3a82cdf3573f6..7984fdfc0ffbf0 100644 --- a/test/parallel/test-http-set-timeout-server.js +++ b/test/parallel/test-http-set-timeout-server.js @@ -152,6 +152,7 @@ test(function serverResponseTimeoutWithPipeline(cb) { }); test(function idleTimeout(cb) { + // Test that the an idle connection invokes the timeout callback. const server = http.createServer(); const s = server.setTimeout(50, common.mustCall((socket) => { socket.destroy(); @@ -165,6 +166,7 @@ test(function idleTimeout(cb) { allowHalfOpen: true, }; const c = net.connect(options, () => { + // ECONNRESET could happen on a heavily-loaded server. c.on('error', (e) => { if (e.message !== 'read ECONNRESET') throw e; diff --git a/test/parallel/test-https-set-timeout-server.js b/test/parallel/test-https-set-timeout-server.js index a73b285939089c..b5cc8a6f5a2664 100644 --- a/test/parallel/test-https-set-timeout-server.js +++ b/test/parallel/test-https-set-timeout-server.js @@ -173,6 +173,7 @@ test(function serverResponseTimeoutWithPipeline(cb) { }); test(function idleTimeout(cb) { + // Test that the an idle connection invokes the timeout callback. const server = https.createServer(serverOptions); const s = server.setTimeout(50, common.mustCall((socket) => { socket.destroy(); @@ -187,6 +188,7 @@ test(function idleTimeout(cb) { rejectUnauthorized: false }; const c = tls.connect(options, () => { + // ECONNRESET could happen on a heavily-loaded server. c.on('error', (e) => { if (e.message !== 'read ECONNRESET') throw e; @@ -198,6 +200,7 @@ test(function idleTimeout(cb) { }); test(function fastTimeout(cb) { + // Test that the socket timeout fires but no timeout fires for the request. let connectionHandlerInvoked = false; let timeoutHandlerInvoked = false; let connectionSocket;