diff --git a/src/api/environment.cc b/src/api/environment.cc index c0096fb79bcf46..dec43ee3a6c836 100644 --- a/src/api/environment.cc +++ b/src/api/environment.cc @@ -363,11 +363,13 @@ Local NewContext(Isolate* isolate, auto context = Context::New(isolate, nullptr, object_template); if (context.IsEmpty()) return context; - return MaybeInitializeContext(context, object_template); + if (!InitializeContext(context)) { + return Local(); + } + return context; } -Local MaybeInitializeContext(Local context, - Local object_template) { +bool InitializeContext(Local context) { Isolate* isolate = context->GetIsolate(); HandleScope handle_scope(isolate); @@ -389,7 +391,7 @@ Local MaybeInitializeContext(Local context, if (!primordials->SetPrototype(context, Null(isolate)).FromJust() || !GetPerContextExports(context).ToLocal(&exports) || !exports->Set(context, primordials_string, primordials).FromJust()) { - return Local(); + return false; } static const char* context_files[] = {"internal/per_context/primordials", @@ -405,7 +407,7 @@ Local MaybeInitializeContext(Local context, native_module::NativeModuleEnv::LookupAndCompile( context, *module, ¶meters, nullptr); if (maybe_fn.IsEmpty()) { - return Local(); + return false; } Local fn = maybe_fn.ToLocalChecked(); MaybeLocal result = @@ -414,12 +416,12 @@ Local MaybeInitializeContext(Local context, // Execution failed during context creation. // TODO(joyeecheung): deprecate this signature and return a MaybeLocal. if (result.IsEmpty()) { - return Local(); + return false; } } } - return context; + return true; } uv_loop_t* GetCurrentEventLoop(Isolate* isolate) { diff --git a/src/node.h b/src/node.h index 37ae0e433ca7a3..a52f242cac1360 100644 --- a/src/node.h +++ b/src/node.h @@ -306,10 +306,8 @@ NODE_EXTERN v8::Local NewContext( v8::Local()); // Runs Node.js-specific tweaks on an already constructed context -NODE_EXTERN v8::Local MaybeInitializeContext( - v8::Local context, - v8::Local object_template = - v8::Local()); +// Return value indicates success of operation +NODE_EXTERN bool InitializeContext(v8::Local context); // If `platform` is passed, it will be used to register new Worker instances. // It can be `nullptr`, in which case creating new Workers inside of