From 2a0fa4792eb707347a245b17ec9730e08da99a32 Mon Sep 17 00:00:00 2001 From: Vse Mozhet Byt Date: Thu, 26 Jul 2018 00:37:57 +0300 Subject: [PATCH] doc: do not advise to cancel full CI on onboarding MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Refs: https://github.com/nodejs/node/pull/21938#discussion_r204257281 and discussion below the comment. PR-URL: https://github.com/nodejs/node/pull/21977 Reviewed-By: Matheus Marchini Reviewed-By: Refael Ackermann Reviewed-By: Richard Lau Reviewed-By: João Reis Reviewed-By: Jon Moss Reviewed-By: Rich Trott Reviewed-By: Anatoli Papirovski --- doc/onboarding.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index b6464ebae4559f..3a03edb17e8169 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -213,9 +213,7 @@ needs to be pointed out separately during the onboarding. * Optionally, include your personal pronouns. * Label your pull request with the `doc` and `notable-change` labels. * Run CI on the PR. Because the PR does not affect any code, use the - `node-test-pull-request-lite-pipeline` CI task. Alternatively, use the usual - `node-test-pull-request` CI task and cancel it after the linter and one other - subtask have passed. + `node-test-pull-request-lite-pipeline` CI task. * After one or two approvals, land the PR (PRs of this type do not need to wait for 48/72 hours to land). * Be sure to add the `PR-URL: ` and appropriate `Reviewed-By:`