From 2147e496e7f2071ecda4551d4f6d1fc194ea99af Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Fri, 18 Oct 2024 16:52:00 +0000 Subject: [PATCH] build: tidy up cares.gyp Add comment noting that `cares_sources_common` is generated by tooling. Remove duplicated entries. PR-URL: https://github.com/nodejs/node/pull/55445 Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli --- deps/cares/cares.gyp | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/deps/cares/cares.gyp b/deps/cares/cares.gyp index ef43c25a47ff34..c34ad7370ca45a 100644 --- a/deps/cares/cares.gyp +++ b/deps/cares/cares.gyp @@ -1,5 +1,6 @@ { 'variables': { + # This list is generated by `tools/dep_updaters/update-c-ares.mjs`. 'cares_sources_common': [ 'include/ares.h', 'include/ares_build.h', @@ -135,13 +136,6 @@ ], 'cares_sources_mac': [ 'config/darwin/ares_config.h', - 'src/lib/ares_sysconfig_mac.c', - 'src/lib/thirdparty/apple/dnsinfo.h', - ], - 'cares_sources_win': [ - 'src/lib/ares_sysconfig_win.c', - 'src/lib/config-win32.h', - 'src/lib/windows_port.c', ], }, @@ -203,9 +197,6 @@ '_WINSOCK_DEPRECATED_NO_WARNINGS', ], 'include_dirs': [ 'config/win32' ], - 'sources': [ - '<@(cares_sources_win)', - ], 'libraries': [ '-lws2_32.lib', '-liphlpapi.lib'