From 1e4a2bcbee3559f9d665ba54a27991af9f24ff30 Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Sat, 3 Apr 2021 21:58:18 -0700
Subject: [PATCH] crypto: remove check for condition that is always true

The value of `key` will always be `!= null` because earlier in the
function, `ERR_CRYPTO_SIGN_KEY_REQUIRED` is thrown if `key` is falsy.
Remove condition that subsequently checks that `key != null`.

PR-URL: https://github.com/nodejs/node/pull/38072
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 lib/internal/crypto/sig.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/internal/crypto/sig.js b/lib/internal/crypto/sig.js
index d5c4c46192cd17..f6b9d9d9a994e7 100644
--- a/lib/internal/crypto/sig.js
+++ b/lib/internal/crypto/sig.js
@@ -177,7 +177,7 @@ function signOneShot(algorithm, data, key, callback) {
   let keyData;
   if (isKeyObject(key) || isCryptoKey(key)) {
     ({ data: keyData } = preparePrivateKey(key));
-  } else if (key != null && (isKeyObject(key.key) || isCryptoKey(key.key))) {
+  } else if (isKeyObject(key.key) || isCryptoKey(key.key)) {
     ({ data: keyData } = preparePrivateKey(key.key));
   } else {
     keyData = createPrivateKey(key)[kHandle];