From 1c494b0a9500d4ec27330ff7ed55865112a5ee77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Wed, 13 Mar 2019 10:55:48 +0100 Subject: [PATCH] deps: silence irrelevant V8 warnings PR-URL: https://github.com/nodejs/node/pull/25852 Reviewed-By: Ujjwal Sharma Reviewed-By: Matteo Collina Reviewed-By: Ali Ijaz Sheikh --- deps/v8/gypfiles/toolchain.gypi | 2 +- deps/v8/include/v8.h | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/deps/v8/gypfiles/toolchain.gypi b/deps/v8/gypfiles/toolchain.gypi index 6da48e2282207c..10109024ba3ba3 100644 --- a/deps/v8/gypfiles/toolchain.gypi +++ b/deps/v8/gypfiles/toolchain.gypi @@ -1393,7 +1393,7 @@ ], # conditions }, # Release }, # configurations - 'cflags': [ '-Wno-type-limits', ], + 'cflags!': [ '-Wall', '-Wextra' ], 'msvs_disabled_warnings': [ 4245, # Conversion with signed/unsigned mismatch. 4267, # Conversion with possible loss of data. diff --git a/deps/v8/include/v8.h b/deps/v8/include/v8.h index 97e3584d0befe1..c5d9fc3a97525a 100644 --- a/deps/v8/include/v8.h +++ b/deps/v8/include/v8.h @@ -4337,14 +4337,13 @@ class V8_EXPORT CompiledWasmModule { class V8_EXPORT WasmModuleObject : public Object { public: // TODO(clemensh): Remove after 7.3 branch. - V8_DEPRECATED("Use OwnedBuffer", typedef) - std::pair, size_t> SerializedModule; + typedef std::pair, size_t> SerializedModule; /** * A unowned reference to a byte buffer. * TODO(clemensh): Remove after 7.3 branch. */ - V8_DEPRECATED("Use MemorySpan", struct) BufferReference { + struct BufferReference { const uint8_t* start; size_t size; BufferReference(const uint8_t* start, size_t size)