Skip to content

Commit 19c1c71

Browse files
Matheus Marchinigibfahn
Matheus Marchini
authored andcommittedDec 20, 2017
build: define HAVE_OPENSSL macro for cctest
cctest build target wasn't defining the HAVE_OPENSSL macro when node_use_openssl was true, causing inconsistencies on most `node::Environment` member's addresses. For example, if someone wanted to access the context of an environment by using `node::Environment::context()`, the object returned by the function was pointing to an invalid address. PR-URL: #17461 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 101b0c7 commit 19c1c71

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed
 

‎node.gyp

+3
Original file line numberDiff line numberDiff line change
@@ -841,6 +841,9 @@
841841
'<(OBJ_PATH)<(OBJ_SEPARATOR)node_crypto_clienthello.<(OBJ_SUFFIX)',
842842
'<(OBJ_PATH)<(OBJ_SEPARATOR)tls_wrap.<(OBJ_SUFFIX)',
843843
],
844+
'defines': [
845+
'HAVE_OPENSSL=1',
846+
],
844847
}],
845848
['v8_enable_inspector==1', {
846849
'sources': [

0 commit comments

Comments
 (0)
Please sign in to comment.