From 18f073f0fed709bad10d1bd03a5b7d7b57a409d3 Mon Sep 17 00:00:00 2001 From: Gibson Fahnestock Date: Tue, 13 Jun 2017 14:26:15 +0100 Subject: [PATCH] build: fail linter if linting not available MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/13658 Ref: https://github.com/nodejs/node/pull/13645#issuecomment-308100452 Reviewed-By: João Reis Reviewed-By: Refael Ackermann Reviewed-By: Roman Reiss Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen --- Makefile | 1 + vcbuild.bat | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index da37eab4550069..1aa317c88f01f0 100644 --- a/Makefile +++ b/Makefile @@ -924,6 +924,7 @@ lint: @echo "Linting is not available through the source tarball." @echo "Use the git repo instead:" \ "$ git clone https://github.com/nodejs/node.git" + exit 1 lint-ci: lint endif diff --git a/vcbuild.bat b/vcbuild.bat index 8c9658b7e3d9a5..41a82e1551af87 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -485,7 +485,7 @@ goto exit :no-lint echo Linting is not available through the source tarball. echo Use the git repo instead: $ git clone https://github.com/nodejs/node.git -goto exit +exit /b 1 :create-msvs-files-failed echo Failed to create vc project files.