From 071836aa4262d4178310c1b8215e9498c47adbde Mon Sep 17 00:00:00 2001 From: Pedro Victor Date: Sat, 29 Oct 2016 13:04:54 -0200 Subject: [PATCH] repl: name anonymous functions the changes are related to https://github.com/nodejs/node/issues/8913 regarding the naming of just the inline anonymous functions that are not assigned to a variable PR-URL: https://github.com/nodejs/node/pull/9356 Reviewed-By: Rich Trott Reviewed-By: James M Snell Reviewed-By: Roman Reiss --- lib/repl.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/repl.js b/lib/repl.js index cac79c5e2188f3..d00757b5125571 100644 --- a/lib/repl.js +++ b/lib/repl.js @@ -354,7 +354,7 @@ function REPLServer(prompt, self.eval = self._domain.bind(eval_); - self._domain.on('error', function(e) { + self._domain.on('error', function debugDomainError(e) { debug('domain error'); const top = replMap.get(self); internalUtil.decorateErrorStack(e); @@ -436,13 +436,13 @@ function REPLServer(prompt, }; } - self.on('close', function() { + self.on('close', function emitExit() { self.emit('exit'); }); var sawSIGINT = false; var sawCtrlD = false; - self.on('SIGINT', function() { + self.on('SIGINT', function onSigInt() { var empty = self.line.length === 0; self.clearLine(); self.turnOffEditorMode(); @@ -465,7 +465,7 @@ function REPLServer(prompt, self.displayPrompt(); }); - self.on('line', function(cmd) { + self.on('line', function onLine(cmd) { debug('line %j', cmd); sawSIGINT = false; @@ -586,7 +586,7 @@ function REPLServer(prompt, } }); - self.on('SIGCONT', function() { + self.on('SIGCONT', function onSigCont() { if (self.editorMode) { self.outputStream.write(`${self._initialPrompt}.editor\n`); self.outputStream.write( @@ -951,7 +951,7 @@ function complete(line, callback) { addStandardGlobals(completionGroups, filter); completionGroupsLoaded(); } else { - this.eval('.scope', this.context, 'repl', function(err, globals) { + this.eval('.scope', this.context, 'repl', function ev(err, globals) { if (err || !Array.isArray(globals)) { addStandardGlobals(completionGroups, filter); } else if (Array.isArray(globals[0])) { @@ -968,7 +968,7 @@ function complete(line, callback) { } } else { const evalExpr = `try { ${expr} } catch (e) {}`; - this.eval(evalExpr, this.context, 'repl', function(e, obj) { + this.eval(evalExpr, this.context, 'repl', function doEval(e, obj) { // if (e) console.log(e); if (obj != null) {