readline close not emitted if input is stdin

[belak]

I've been working with node.js a little and I'm trying to read some config values in through stdin on program start. This is what I came up with:

https://gist.github.com/anonymous/5392981

However, when running like the following, it only outputs "end", not "closed"

echo hello | node test.js

Adding terminal: false fixes it, but according to the docs this shouldn't be the case.
https://gist.github.com/gluxon/5393130

The docs say that any time input's "end" is triggered, readline's "close" should be.

Is this just something I'm missing, or is this an actual issue?

[hackedy]

I think this got introduced in PR #2922 (specifically commit aad12d0), but I'm not certain. I can verify that tomorrow.

Regardless of its origin, this needs a patch. (unless this is intended behavior 😞)

[bnoordhuis]

It's because lib/readline.js checks if output.isTTY === true, which it always is for process.stdout, whether or not STDOUT_FILENO is actually a tty. It's a bug in lib/tty.js because it unconditionally sets WriteStream.prototype.isTTY = true

[jasnell]

Unable to reproduce in v0.12 using the provided test case. Closing. Can reopen if new information is received.

[belak]

This does appear to work now. Thanks for the follow up!