0.4.x -> 0.6.x net.Server.close behavior change

[bobrik]

Here's my git explaining everything: https://gist.github.com/1521447

Maybe docs really should be updated? I relied on the old behavior and had some headache with updating.

[bobrik]

The main question for what I want to see an answer in docs: is server stops accepting new connections immediately (sync call)?

[bnoordhuis]

is server stops accepting new connections immediately (sync call)?

It's complicated. The official story is that the server is active until you receive the close event.

Back story: The server socket is closed immediately (i.e. synchronously) but you can still receive a number of 'new' connections that have been accept()-ed and queued at the start of the event loop's current tick. Hence the need to wait for the close event.

I've updated the documentation in 70e6f3f.

[bobrik]

Maybe it's better to emit close when no new connections can be received? I may work around current behavior, but it should be more consistent imho.

[bnoordhuis]

Maybe you're right. I've started a discussion in commit 09ee293.

[bnoordhuis]

Fixed in c24276f.

[bobrik]

Thanks a lot! :)