Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

CI setup for node-inspect #21

Closed
joshgav opened this issue Feb 13, 2017 · 9 comments
Closed

CI setup for node-inspect #21

joshgav opened this issue Feb 13, 2017 · 9 comments
Assignees

Comments

@joshgav
Copy link
Contributor

joshgav commented Feb 13, 2017

Travis and Appveyor configurations are specified in the repo, but the Node.js projects don't generally support integration with Travis (see e.g. nodejs/github-bot#57).

So we can either set up this repo to be tested by Node's own Jenkins CI, or perhaps make arrangements to use Travis like citgm.

CI work is in progress for node-report too in nodejs/node-report#18 and nodejs/build#610. @mhdawson based on your work there can you suggest the right approach for node-inspect?

@mhdawson
Copy link
Member

To get coverage across our platforms it really needs to be the Node.js Jenkins CI.

If we are in agreement I can open the issue to get the ok to setup jobs based on: https://github.com/nodejs/build/blob/master/doc/process/jenkins_job_configuation_access.md

That would let us setup a "node-inspect" team who's members could start the jobs and "node-inspect-admin" team who could edit the jobs.

If its simply a matter of a job that install the module and then runs the tests I can then one up based on what was done for node-report.

@jkrems
Copy link
Collaborator

jkrems commented Feb 14, 2017

npm install / npm test with build status would definitely be great.

On travis I had also a setup for automated PR labels & releases from CI (potentially using a shared/headless user). Not sure if anything like that exists for some node core project..? Otherwise I can do the releases manually from my machine using my own github/npm credentials.

@mhdawson
Copy link
Member

In terms of release I think we'd also like something like that in the Node.js CI. We need the same thing for node-report and I've go the action to see how we can setup a common "nodejs" identity that we can use for publishing the modules.

Maybe we can re-use your automated setup, I think @sam-github had mentioned that there are some strongloop tools/scripts for publishing modules we should look at.

@mhdawson
Copy link
Member

I assume that testing node-inspect should be associated with the diagnostics wg.

@mhdawson
Copy link
Member

mhdawson commented Feb 14, 2017

Created nodejs/build#625 to start process as documented for getting CI jobs for a workgroup.

@mhdawson
Copy link
Member

@mhdawson mhdawson self-assigned this Feb 14, 2017
@rnchamberlain
Copy link

@mhdawson Oi! I am getting (lots of) email reports from these node-inspect CI builds. I guess the config was copied from node-report, including my email address. The email address is in the "Post-build Actions" panel right at the bottom of the config, but I don't have powers on node-inspect to fix it.

Incidently, we've made a few changes recently to the node-report CI config, including switching from using citgm to just direct 'npm test' - which improves the console output a lot. Might be worth copying that.

@jkrems
Copy link
Collaborator

jkrems commented Mar 15, 2017

@mhdawson Did you have time to look into the notification settings and/or simplifying the setup to use npm test directly? Or would you prefer to track this in a separate issue?

@jkrems
Copy link
Collaborator

jkrems commented Aug 31, 2020

The repo now uses a Github workflow for testing.

@jkrems jkrems closed this as completed Aug 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants