Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--silent flag is not respected. #2489

Open
serkanyersen opened this issue Aug 27, 2021 · 0 comments
Open

--silent flag is not respected. #2489

serkanyersen opened this issue Aug 27, 2021 · 0 comments
Labels

Comments

@serkanyersen
Copy link

serkanyersen commented Aug 27, 2021

  • Node Version: v14.15.1 and 7.5.4
  • Platform: Darwin seko-mbp 20.6.0 Darwin Kernel Version 20.6.0: Wed Jun 23 00:26:31 PDT 2021; root:xnu-7195.141.2~5/RELEASE_X86_64 x86_64
  • Compiler: Apple clang version 12.0.0 (clang-1200.0.32.21)
    Target: x86_64-apple-darwin20.6.0
    Thread model: posix
    InstalledDir: /Applications/Xcode_12.1.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
  • Module: general use via node api.

When used via node api, --silent flag is not respected. Code here https://github.com/nodejs/node-gyp/blob/master/lib/node-gyp.js#L170-L172

  if (!opts.silent && !opts.stdio) {
    opts.stdio = [0, 1, 2]
  }

is setting the stdio to inherit but this does not make it silent if the parent script is not silent.

in this situation, setting this to ['ignore', 'ignore', 'ignore'] might be better, which will make it truly silent. In it's current state output is reduced but it's still printing out unexpected lines in the terminal.

More information can be found here electron/rebuild#594

@cclauss cclauss added the macOS label Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants