test: configure proper devDir for invoking configure()

rvagg · rvagg · commit 8d79000ad17d · 2019-10-30T21:31:39.000+11:00
test/test-configure-python.js downloads a fresh set of headers to the
package directory each time. By setting to the default global cache dir
we get to re-use cached headers and skip the download step.
diff --git a/test/common.js b/test/common.js
@@ -0,0 +1,3 @@
+const envPaths = require('env-paths')
+
+module.exports.devDir = () => envPaths('node-gyp', { suffix: '' }).cache
diff --git a/test/test-configure-python.js b/test/test-configure-python.js
@@ -30,6 +30,7 @@ test('configure PYTHONPATH with no existing env', function (t) {
     t.equal(process.env.PYTHONPATH, EXPECTED_PYPATH)
     return SPAWN_RESULT
   }
+  prog.devDir = devDir
   configure(prog, [], t.fail)
 })
 
@@ -49,6 +50,7 @@ test('configure PYTHONPATH with existing env of one dir', function (t) {
 
     return SPAWN_RESULT
   }
+  prog.devDir = devDir
   configure(prog, [], t.fail)
 })
 
@@ -70,5 +72,6 @@ test('configure PYTHONPATH with existing env of multiple dirs', function (t) {
 
     return SPAWN_RESULT
   }
+  prog.devDir = devDir
   configure(prog, [], t.fail)
 })

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+const envPaths = require('env-paths')`
	`2`	`+`
	`3`	`+module.exports.devDir = () => envPaths('node-gyp', { suffix: '' }).cache`
Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@ test('configure PYTHONPATH with no existing env', function (t) {`
`30`	`30`	`t.equal(process.env.PYTHONPATH, EXPECTED_PYPATH)`
`31`	`31`	`return SPAWN_RESULT`
`32`	`32`	`}`
	`33`	`+ prog.devDir = devDir`
`33`	`34`	`configure(prog, [], t.fail)`
`34`	`35`	`})`
`35`	`36`
`@@ -49,6 +50,7 @@ test('configure PYTHONPATH with existing env of one dir', function (t) {`
`49`	`50`
`50`	`51`	`return SPAWN_RESULT`
`51`	`52`	`}`
	`53`	`+ prog.devDir = devDir`
`52`	`54`	`configure(prog, [], t.fail)`
`53`	`55`	`})`
`54`	`56`
`@@ -70,5 +72,6 @@ test('configure PYTHONPATH with existing env of multiple dirs', function (t) {`
`70`	`72`
`71`	`73`	`return SPAWN_RESULT`
`72`	`74`	`}`
	`75`	`+ prog.devDir = devDir`
`73`	`76`	`configure(prog, [], t.fail)`
`74`	`77`	`})`