Skip to content

Commit 7cf5079

Browse files
richardlaurvagg
authored andcommittedNov 18, 2019
src,win: allow 403 errors for arm64 node.lib
The servers hosting the header packages for Electron return 403 instead of 404 for the constructed URL for arm64 node.lib for older releases that do not support arm64. PR-URL: #1934 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: João Reis <reis@janeasystems.com>
1 parent ad0d182 commit 7cf5079

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎lib/install.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ function install (fs, gyp, argv, callback) {
323323

324324
req.on('error', done)
325325
req.on('response', function (res) {
326-
if (res.statusCode === 404) {
326+
if (res.statusCode === 403 || res.statusCode === 404) {
327327
if (arch === 'arm64') {
328328
// Arm64 is a newer platform on Windows and not all node distributions provide it.
329329
log.verbose(`${name} was not found in ${libUrl}`)

0 commit comments

Comments
 (0)